Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add maintainers email to readme #1315

Merged
merged 1 commit into from
Oct 25, 2024
Merged

add maintainers email to readme #1315

merged 1 commit into from
Oct 25, 2024

Conversation

mbkuhn
Copy link
Contributor

@mbkuhn mbkuhn commented Oct 25, 2024

Summary

Any thoughts on the phrasing? Does this work as a ### level header or should it be in a different part of the readme?

Pull request type

Please check the type of change introduced:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

@mbkuhn mbkuhn requested review from marchdf and moprak-nrel October 25, 2024 15:14
@mbkuhn mbkuhn enabled auto-merge (squash) October 25, 2024 16:02
@marchdf
Copy link
Contributor

marchdf commented Oct 25, 2024

I like the phrasing but I think I would make it at level ## header. Thank you for doing this!

@mbkuhn mbkuhn merged commit 5257b38 into Exawind:main Oct 25, 2024
15 checks passed
@mbkuhn
Copy link
Contributor Author

mbkuhn commented Oct 25, 2024

@marchdf feel free to make another PR if you want to tweak it, I guess. auto-merge! haha

@mbkuhn mbkuhn deleted the readme_email branch October 25, 2024 16:45
@marchdf
Copy link
Contributor

marchdf commented Oct 25, 2024

heh looks fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants